net: stmmac: dwmac-meson8b: Avoid cast to incompatible function type
authorSimon Horman <horms@kernel.org>
Tue, 18 Apr 2023 11:07:33 +0000 (13:07 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 20 Apr 2023 01:40:03 +0000 (18:40 -0700)
commit43bb6100d8d5871d211196034042308c1b1d69c3
treeb14ebb0ed075d31aa62d22c9e7811935b3a1b06f
parent91daa4f62ce878b6e1ac5908aceb83550332447f
net: stmmac: dwmac-meson8b: Avoid cast to incompatible function type

Rather than casting clk_disable_unprepare to an incompatible function
type provide a trivial wrapper with the correct signature for the
use-case.

Reported by clang-16 with W=1:

 drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c:276:6: error: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
                                        (void(*)(void *))clk_disable_unprepare,
                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
No functional change intended.
Compile tested only.

Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Link: https://lore.kernel.org/r/20230418-dwmac-meson8b-clk-cb-cast-v1-1-e892b670cbbb@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c