xsk: avoid store-tearing when assigning umem
authorBjörn Töpel <bjorn.topel@intel.com>
Wed, 4 Sep 2019 11:49:11 +0000 (13:49 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jan 2020 13:51:10 +0000 (14:51 +0100)
commit43a807541949a4bc5fba0eb8b76af453b68ec3f0
treeda460c9e54794abebf259e838e5350000b3625bc
parentc31ead3c88ed00e96ceb482587af224c72d72ee0
xsk: avoid store-tearing when assigning umem

[ Upstream commit 9764f4b301c3e7eb3b75eec85b73cad449cdbb0d ]

The umem member of struct xdp_sock is read outside of the control
mutex, in the mmap implementation, and needs a WRITE_ONCE to avoid
potential store-tearing.

Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Fixes: 423f38329d26 ("xsk: add umem fill queue support and mmap")
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/xdp/xsk.c