projects / platform / kernel / linux-starfive.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b7abf78) | patch
HID: u2fzero: properly handle timeouts in usb_submit_urb
authorAndrej Shadura <andrew.shadura@collabora.co.uk>
Tue, 19 Oct 2021 15:29:17 +0000 (17:29 +0200)
committerJiri Kosina <jkosina@suse.cz>
Wed, 27 Oct 2021 08:17:08 +0000 (10:17 +0200)
commit43775e62c4b784f44a159e13ba80e6146a42d502
treebc67d48a4bcfaea144a0b2736910c329584f317btree | snapshot
parentb7abf78b7a6c4a29a6e0ba0bb883fe44a2f3d693commit | diff
HID: u2fzero: properly handle timeouts in usb_submit_urb

The wait_for_completion_timeout function returns 0 if timed out or a
positive value if completed. Hence, "less than zero" comparison always
misses timeouts and doesn't kill the URB as it should, leading to
re-sending it while it is active.

Fixes: 42337b9d4d95 ("HID: add driver for U2F Zero built-in LED and RNG")
Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-u2fzero.c diff | blob | history
Domain: System / Kernel;