drm/msm: Depopulate platform on probe failure
authorSean Paul <seanpaul@chromium.org>
Mon, 17 Jun 2019 20:12:51 +0000 (16:12 -0400)
committerSean Paul <seanpaul@chromium.org>
Thu, 20 Jun 2019 18:42:05 +0000 (14:42 -0400)
commit4368a1539c6b41ac3cddc06f5a5117952998804c
treeb26fe7ab18946a7a4e29f7dcf6484b7f5c19531f
parent8b3c087a7998fc5db10b2a9fc850dfc295306c20
drm/msm: Depopulate platform on probe failure

add_display_components() calls of_platform_populate, and we depopluate
on pdev remove, but not when probe fails. So if we get a probe deferral
in one of the components, we won't depopulate the platform. This causes
the core to keep references to devices which should be destroyed, which
causes issues when those same devices try to re-initialize on the next
probe attempt.

I think this is the reason we had issues with the gmu's device-managed
resources on deferral (worked around in commit 94e3a17f33a5).

Reviewed-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190617201301.133275-3-sean@poorly.run
drivers/gpu/drm/msm/msm_drv.c