net: remove bypassed check in sch_direct_xmit()
authorSong Liu <songliubraving@fb.com>
Tue, 29 May 2018 17:03:21 +0000 (10:03 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 31 May 2018 17:26:19 +0000 (13:26 -0400)
commit4341f8308d53f95a4a1ab54f45fa9af2c30ff596
tree6f21283731f7246aaa632b5d721f926f9355e1bc
parent3d97d88e8091f3501e016f6b4ce45a32c4b8f2f6
net: remove bypassed check in sch_direct_xmit()

Checking netif_xmit_frozen_or_stopped() at the end of sch_direct_xmit()
is being bypassed. This is because "ret" from sch_direct_xmit() will be
either NETDEV_TX_OK or NETDEV_TX_BUSY, and only ret == NETDEV_TX_OK == 0
will reach the condition:

    if (ret && netif_xmit_frozen_or_stopped(txq))
        return false;

This patch cleans up the code by removing the whole condition.

For more discussion about this, please refer to
   https://marc.info/?t=152727195700008

Signed-off-by: Song Liu <songliubraving@fb.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_generic.c