firmware: qemu_fw_cfg: fix sysfs information leak
authorJohan Hovold <johan@kernel.org>
Wed, 1 Dec 2021 13:25:27 +0000 (14:25 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Dec 2021 09:14:52 +0000 (10:14 +0100)
commit433b7cd1e702b0918ef90cbf06c3da24313625d2
tree3bfe692bdd9e3d13aae9916b19ec7e7f1782c401
parent47a1db8e797da01a1309bf42e0c0d771d4e4d4f3
firmware: qemu_fw_cfg: fix sysfs information leak

Make sure to always NUL-terminate file names retrieved from the firmware
to avoid accessing data beyond the entry slab buffer and exposing it
through sysfs in case the firmware data is corrupt.

Fixes: 75f3e8e47f38 ("firmware: introduce sysfs driver for QEMU's fw_cfg device")
Cc: stable@vger.kernel.org # 4.6
Cc: Gabriel Somlo <somlo@cmu.edu>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20211201132528.30025-4-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/qemu_fw_cfg.c