Fix crash in signal change notification override
authorChris Adams <christopher.adams@nokia.com>
Wed, 25 Jul 2012 01:03:35 +0000 (11:03 +1000)
committerQt by Nokia <qt-info@nokia.com>
Thu, 16 Aug 2012 04:42:33 +0000 (06:42 +0200)
commit4317c442fd492121e2fc037a39b40653bbc34294
treea3774e09b4f7184316b445886486a6eb77346245
parentee0a9ce6518f4423dec83102293dcc5b9c0d4c7f
Fix crash in signal change notification override

Manual overrides of automatically generated property change
notification signals can cause crashes.  They also don't work
properly in the situations where they don't crash.  This patch
ensures that it is now a compile error to attempt to override a
signal with a manual signal or slot.

Note that this includes signals defined in superclasses.

Task-number: QTBUG-26723
Task-number: QTBUG-26818
Change-Id: I4ecf448ce9de5d97526606126991e280debea2d6
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
14 files changed:
src/qml/qml/qqmlcompiler.cpp
tests/auto/qml/qqmllanguage/data/OverrideSignalComponent.qml [new file with mode: 0644]
tests/auto/qml/qqmllanguage/data/overrideSignal.1.errors.txt [new file with mode: 0644]
tests/auto/qml/qqmllanguage/data/overrideSignal.1.qml [new file with mode: 0644]
tests/auto/qml/qqmllanguage/data/overrideSignal.2.errors.txt [new file with mode: 0644]
tests/auto/qml/qqmllanguage/data/overrideSignal.2.qml [new file with mode: 0644]
tests/auto/qml/qqmllanguage/data/overrideSignal.3.qml [new file with mode: 0644]
tests/auto/qml/qqmllanguage/data/overrideSignal.4.errors.txt [new file with mode: 0644]
tests/auto/qml/qqmllanguage/data/overrideSignal.4.qml [new file with mode: 0644]
tests/auto/qml/qqmllanguage/data/overrideSignal.5.errors.txt [new file with mode: 0644]
tests/auto/qml/qqmllanguage/data/overrideSignal.5.qml [new file with mode: 0644]
tests/auto/qml/qqmllanguage/data/overrideSignal.6.errors.txt [new file with mode: 0644]
tests/auto/qml/qqmllanguage/data/overrideSignal.6.qml [new file with mode: 0644]
tests/auto/qml/qqmllanguage/tst_qqmllanguage.cpp