Relax language comparison when matching up C++ forward decls with definitions
authorAdrian Prantl <aprantl@apple.com>
Thu, 17 Jun 2021 01:17:58 +0000 (18:17 -0700)
committerAdrian Prantl <aprantl@apple.com>
Thu, 17 Jun 2021 01:21:43 +0000 (18:21 -0700)
commit42e2a90684196d6ffadf785e98ea5de0876b4a3e
tree91151bf2149d2e43902ab88ea934d19a3f2ecff2
parent562bfe1274a17698c445ee3d7bb4a7911d74f657
Relax language comparison when matching up C++ forward decls with definitions

when dealing with -gmodules debug info.

This fixes the bot failures on Darwin.

A recent clang change (presumably https://reviews.llvm.org/D104291)
introduced a bug where .pcm files would identify themselves as
DW_LANG_C_plus_plus, but the .o that references them would identify as
DW_LANG_C_plus_plus_14. While that bug needs to be fixed, too, it
shows that the current strict comparison also isn't meaningful.

rdar://79423225
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h