[Libomptarget] Build plugins with protected visibility by default
authorJoseph Huber <jhuber6@vols.utk.edu>
Thu, 20 Oct 2022 15:51:46 +0000 (10:51 -0500)
committerJoseph Huber <jhuber6@vols.utk.edu>
Thu, 20 Oct 2022 16:12:18 +0000 (11:12 -0500)
commit429d3d4e9d8dd9f8a07c5304b7d840395521c882
tree2161a94f3fff043c66064279528fa7f6905e7dce
parent62eae8372d4c83b27b159dce5c9d10ffe7392bb8
[Libomptarget] Build plugins with protected visibility by default

The plugins all define the same interface symbols. This is generally not
a problem when calling the plugin directly from the dynamic library's
handle. However, when calling from within the plugin itself it is
possible for another plugin's symbols to preempt the symbols. This was
observed with the `__tgt_rtl_is_valid_binary` call in the
`__tgt_rtl_is_valid_binary_info` function being mapped to the x86_64
plugin.

This patch changes the default visibility to `protected` intead. This
visibility ensures that these symbols are all externally visible from
the plugin, but ensures their definitions are fixed within the shared
library. Having protected visiiblity makes such symbol preemption
impossible.

Reviewed By: tianshilei1992

Differential Revision: https://reviews.llvm.org/D136365
openmp/libomptarget/plugins/CMakeLists.txt
openmp/libomptarget/plugins/amdgpu/CMakeLists.txt
openmp/libomptarget/plugins/cuda/CMakeLists.txt
openmp/libomptarget/plugins/ve/CMakeLists.txt