NFSD: Ensure nf_inode is never dereferenced
authorChuck Lever <chuck.lever@oracle.com>
Fri, 8 Jul 2022 18:27:09 +0000 (14:27 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Sat, 30 Jul 2022 00:16:56 +0000 (20:16 -0400)
commit427f5f83a3191cbf024c5aea6e5b601cdf88d895
treefdd97a04ea12d861ccf06dadd59f737845a74744
parent5e138c4a750dc140d881dab4a8804b094bbc08d2
NFSD: Ensure nf_inode is never dereferenced

The documenting comment for struct nf_file states:

/*
 * A representation of a file that has been opened by knfsd. These are hashed
 * in the hashtable by inode pointer value. Note that this object doesn't
 * hold a reference to the inode by itself, so the nf_inode pointer should
 * never be dereferenced, only used for comparison.
 */

Replace the two existing dereferences to make the comment always
true.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/filecache.c
fs/nfsd/filecache.h
fs/nfsd/nfs4state.c