KVM: x86: Keep the lock order consistent between SRCU and gpc spinlock
authorPeng Hao <flyingpeng@tencent.com>
Tue, 8 Nov 2022 03:50:54 +0000 (11:50 +0800)
committerSean Christopherson <seanjc@google.com>
Thu, 1 Dec 2022 00:00:02 +0000 (16:00 -0800)
commit4265df667bbdc71c640e43c905bd9aeeead92365
treeba2beb9e7e3c566280e874252b54f33f695b5a79
parenteb3992e833d3a17f9b0a3e0371d0b1d3d566f740
KVM: x86: Keep the lock order consistent between SRCU and gpc spinlock

Acquire SRCU before taking the gpc spinlock in wait_pending_event() so as
to be consistent with all other functions that acquire both locks.  It's
not illegal to acquire SRCU inside a spinlock, nor is there deadlock
potential, but in general it's preferable to order locks from least
restrictive to most restrictive, e.g. if wait_pending_event() needed to
sleep for whatever reason, it could do so while holding SRCU, but would
need to drop the spinlock.

Signed-off-by: Peng Hao <flyingpeng@tencent.com>
Reviewed-by: Sean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/r/CAPm50a++Cb=QfnjMZ2EnCj-Sb9Y4UM-=uOEtHAcjnNLCAAf-dQ@mail.gmail.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/xen.c