tracing: Have saved_cmdlines use the seq_read infrastructure
authorYoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Thu, 20 Feb 2014 08:44:31 +0000 (17:44 +0900)
committerSteven Rostedt <rostedt@goodmis.org>
Fri, 30 May 2014 03:08:07 +0000 (23:08 -0400)
commit42584c81c5adc1737a6fe0687facc5e62a5dc8c1
tree25dbedd93aa7618d436495cce800627cf1761d8e
parent81dc9f0ef21e40114cc895894c7acf3055f6d1fb
tracing: Have saved_cmdlines use the seq_read infrastructure

Current tracing_saved_cmdlines_read() implementation is naive; It allocates
a large buffer, constructs output data to that buffer for each read
operation, and then copies a portion of the buffer to the user space
buffer. This has several issues such as slow memory allocation, high
CPU usage, and even corruption of the output data.

The seq_read infrastructure is made to handle this type of work.
By converting it to use seq_read() the code becomes smaller, simplified,
as well as correct.

Link: http://lkml.kernel.org/p/20140220084431.3839.51793.stgit@yunodevel
Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace.c