wifi: iwlwifi: dbg_ini: fix structure packing
authorArnd Bergmann <arnd@arndb.de>
Fri, 16 Jun 2023 09:03:34 +0000 (11:03 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 11 Sep 2023 13:55:03 +0000 (15:55 +0200)
commit424c82e8ad56756bb98b08268ffcf68d12d183eb
tree68e949cee7070623d7bef2d967b18a34e558ef51
parent2d4caa1dbe915654d0e8845758d9c96e721377a8
wifi: iwlwifi: dbg_ini: fix structure packing

The iwl_fw_ini_error_dump_range structure has conflicting alignment
requirements for the inner union and the outer struct:

In file included from drivers/net/wireless/intel/iwlwifi/fw/dbg.c:9:
drivers/net/wireless/intel/iwlwifi/fw/error-dump.h:312:2: error: field  within 'struct iwl_fw_ini_error_dump_range' is less aligned than 'union iwl_fw_ini_error_dump_range::(anonymous at drivers/net/wireless/intel/iwlwifi/fw/error-dump.h:312:2)' and is usually due to 'struct iwl_fw_ini_error_dump_range' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access]
        union {

As the original intention was apparently to make the entire structure
unaligned, mark the innermost members the same way so the union
becomes packed as well.

Fixes: 973193554cae6 ("iwlwifi: dbg_ini: dump headers cleanup")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230616090343.2454061-1-arnd@kernel.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/fw/error-dump.h