Avoid accessing corrupted stack from __stack_chk_fail [BZ #21752]
authorH.J. Lu <hjl.tools@gmail.com>
Mon, 24 Jul 2017 13:06:08 +0000 (06:06 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Mon, 24 Jul 2017 13:06:24 +0000 (06:06 -0700)
commit422ff87c249ddc06701d096421db63343e4754be
treee095970d350bffebdd21f9fa75a24494aeebbc47
parent55703fcace89b53d7f41f7d85ede50571da2bcc8
Avoid accessing corrupted stack from __stack_chk_fail [BZ #21752]

__libc_argv[0] points to address on stack and __libc_secure_getenv
accesses environment variables which are on stack.  We should avoid
accessing stack when stack is corrupted.

This patch also renames function argument in __fortify_fail_abort
from do_backtrace to need_backtrace to avoid confusion with do_backtrace
from enum __libc_message_action.

[BZ #21752]
* debug/fortify_fail.c (__fortify_fail_abort): Don't pass down
__libc_argv[0] if we aren't doing backtrace.  Rename do_backtrace
to need_backtrace.
* sysdeps/posix/libc_fatal.c (__libc_message): Don't call
__libc_secure_getenv if we aren't doing backtrace.
ChangeLog
debug/fortify_fail.c
sysdeps/posix/libc_fatal.c