Move the -fms-compatibility using decl check after real access checking
authorReid Kleckner <reid@kleckner.net>
Sat, 8 Feb 2014 02:40:20 +0000 (02:40 +0000)
committerReid Kleckner <reid@kleckner.net>
Sat, 8 Feb 2014 02:40:20 +0000 (02:40 +0000)
commit42063b0b1cc6dfb91fca302ac1a1e3432287ba32
tree240de6e8c1996ca4ec1f494dc36b447b2a200292
parent04d6d2f2af6de891688ee107b672aa2fb612204a
Move the -fms-compatibility using decl check after real access checking

Summary:
This avoids false positives from -Wmicrosoft when name lookup would
normally succeed in standard C++.  This triggered on a common CRTP
pattern in clang, where a derived class would have a private using decl
to pull in members of a dependent base:

class Verifier : InstVisitor<Verifier> {
private:
  using InstVisitor<Verifier>::visit;
  ...
  void anything() {
    visit(); // warned here
  }
};

Real access checks pass here because we're in the context of the
Verifier, but the -Wmicrosoft extension was just looking for the private
access specifier.

Reviewers: rsmith

CC: cfe-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D2679

llvm-svn: 201019
clang/lib/Sema/SemaAccess.cpp
clang/test/SemaCXX/MicrosoftCompatibility.cpp