Rename potrs to cholesky_solve (#15334)
authorvishwakftw <cs15btech11043@iith.ac.in>
Wed, 19 Dec 2018 20:11:49 +0000 (12:11 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Wed, 19 Dec 2018 20:31:24 +0000 (12:31 -0800)
commit41e7e1bc40ba8bb50b84afc3addf514549d23336
tree819881b840e02f9581f4d38d45bf8868c1a4f7fd
parent33018e4e09b16075440ea72a6929b15c7ae670f5
Rename potrs to cholesky_solve (#15334)

Summary:
Changelog:
- Renames `potrs` to `cholesky_solve` to remain consistent with Tensorflow and Scipy (not really, they call their function chol_solve)
- Default argument for upper in cholesky_solve is False. This will allow a seamless interface between `cholesky` and `cholesky_solve`, since the `upper` argument in both function are the same.
- Rename all tests
- Create a tentative alias for `cholesky_solve` under the name `potrs`, and add deprecated warning to not promote usage.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/15334

Differential Revision: D13507724

Pulled By: soumith

fbshipit-source-id: b826996541e49d2e2bcd061b72a38c39450c76d0
17 files changed:
aten/src/ATen/core/Tensor.h
aten/src/ATen/core/TensorMethods.h
aten/src/ATen/core/Type.h
aten/src/ATen/core/aten_interned_strings.h
aten/src/ATen/native/BatchLinearAlgebra.cpp
aten/src/ATen/native/LinearAlgebraUtils.h
aten/src/ATen/native/cuda/BatchLinearAlgebra.cu
aten/src/ATen/native/native_functions.yaml
docs/source/tensors.rst
docs/source/torch.rst
test/test_cuda.py
test/test_torch.py
tools/autograd/derivatives.yaml
torch/_tensor_docs.py
torch/_torch_docs.py
torch/functional.py
torch/tensor.py