Make DiagnosticsEngine::takeClient return std::unique_ptr<>
authorAlexander Kornienko <alexfh@google.com>
Mon, 17 Nov 2014 23:46:02 +0000 (23:46 +0000)
committerAlexander Kornienko <alexfh@google.com>
Mon, 17 Nov 2014 23:46:02 +0000 (23:46 +0000)
commit41c247a677f0dafaa13fc05a028275334d5df779
treeed924630113ca0750c462364131a85f1894d8bdf
parentd60b82f93eee090650d848c45f34dcf9d3ffa0ea
Make DiagnosticsEngine::takeClient return std::unique_ptr<>

Summary:
Make DiagnosticsEngine::takeClient return std::unique_ptr<>. Updated
callers to store conditional ownership using a pair of pointer and unique_ptr
instead of a pointer + bool. Updated code that temporarily registers clients to
use the non-owning registration (+ removed extra calls to takeClient).

Reviewers: dblaikie

Reviewed By: dblaikie

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D6294

llvm-svn: 222193
clang/include/clang/Basic/Diagnostic.h
clang/include/clang/Frontend/VerifyDiagnosticConsumer.h
clang/include/clang/Rewrite/Frontend/FixItRewriter.h
clang/lib/Basic/Diagnostic.cpp
clang/lib/Frontend/ASTUnit.cpp
clang/lib/Frontend/CompilerInstance.cpp
clang/lib/Frontend/Rewrite/FixItRewriter.cpp
clang/lib/Frontend/VerifyDiagnosticConsumer.cpp
clang/tools/driver/driver.cpp
clang/unittests/Sema/ExternalSemaSourceTest.cpp