efi: random: fix NULL-deref when refreshing seed
authorJohan Hovold <johan+linaro@kernel.org>
Fri, 16 Dec 2022 09:15:14 +0000 (10:15 +0100)
committerJason A. Donenfeld <Jason@zx2c4.com>
Tue, 20 Dec 2022 02:13:45 +0000 (03:13 +0100)
commit41a15855c1ee390a0ae9d0c29d32b451dd30a600
treed3e2b4f0e9024d7b9d385782e18bcdaedbf1069b
parent6bb20c152b6bf7dd8ffb248f33c2593fd9aeb318
efi: random: fix NULL-deref when refreshing seed

Do not try to refresh the RNG seed in case the firmware does not support
setting variables.

This is specifically needed to prevent a NULL-pointer dereference on the
Lenovo X13s with some firmware revisions, or more generally, whenever
the runtime services have been disabled (e.g. efi=noruntime or with
PREEMPT_RT).

Fixes: e7b813b32a42 ("efi: random: refresh non-volatile random seed when RNG is initialized")
Reported-by: Steev Klimaszewski <steev@kali.org>
Reported-by: Bjorn Andersson <andersson@kernel.org>
Tested-by: Steev Klimaszewski <steev@kali.org>
Tested-by: Andrew Halaney <ahalaney@redhat.com> # sc8280xp-lenovo-thinkpad-x13s
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
drivers/firmware/efi/efi.c