iomap: Fix pipe page leakage during splicing
authorJan Kara <jack@suse.cz>
Fri, 22 Nov 2019 00:14:38 +0000 (16:14 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 22 Nov 2019 16:36:02 +0000 (08:36 -0800)
commit419e9c38aa075ed0cd3c13d47e15954b686bcdb6
tree2856c172882cafbb709ed9c358dc621a55b8a767
parent6334b91e502ca1ec10157f2a3a2c74eea6b5e279
iomap: Fix pipe page leakage during splicing

When splicing using iomap_dio_rw() to a pipe, we may leak pipe pages
because bio_iov_iter_get_pages() records that the pipe will have full
extent worth of data however if file size is not block size aligned
iomap_dio_rw() returns less than what bio_iov_iter_get_pages() set up
and splice code gets confused leaking a pipe page with the file tail.

Handle the situation similarly to the old direct IO implementation and
revert iter to actually returned read amount which makes iter consistent
with value returned from iomap_dio_rw() and thus the splice code is
happy.

Fixes: ff6a9292e6f6 ("iomap: implement direct I/O")
CC: stable@vger.kernel.org
Reported-by: syzbot+991400e8eba7e00a26e1@syzkaller.appspotmail.com
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/iomap/direct-io.c