drm/omap: fix misleading indentation in pixinc()
authorArnd Bergmann <arnd@arndb.de>
Mon, 22 Mar 2021 16:41:57 +0000 (17:41 +0100)
committerTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Fri, 26 Mar 2021 07:13:37 +0000 (09:13 +0200)
commit417fc6123b4a60c60b770e756cc3e001d764e480
tree1c53c7cdca77781ba5a07eea4077503030a7bfc2
parentce517f18944e3f8d08484cfdee425277fc2c4df6
drm/omap: fix misleading indentation in pixinc()

An old patch added a 'return' statement after each BUG() in this driver,
which was necessary at the time, but has become redundant after the BUG()
definition was updated to handle this properly.

gcc-11 now warns about one such instance, where the 'return' statement
was incorrectly indented:

drivers/gpu/drm/omapdrm/dss/dispc.c: In function ‘pixinc’:
drivers/gpu/drm/omapdrm/dss/dispc.c:2093:9: error: this ‘else’ clause does not guard... [-Werror=misleading-indentation]
 2093 |         else
      |         ^~~~
drivers/gpu/drm/omapdrm/dss/dispc.c:2095:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘else’
 2095 |                 return 0;
      |                 ^~~~~~

Address this by removing the return again and changing the BUG()
to be unconditional to make this more intuitive.

Fixes: c6eee968d40d ("OMAPDSS: remove compiler warnings when CONFIG_BUG=n")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210322164203.827324-1-arnd@kernel.org
drivers/gpu/drm/omapdrm/dss/dispc.c