uprobes/tracing: Fully initialize uprobe_trace_consumer before uprobe_register()
authorOleg Nesterov <oleg@redhat.com>
Sun, 27 Jan 2013 17:36:24 +0000 (18:36 +0100)
committerOleg Nesterov <oleg@redhat.com>
Fri, 8 Feb 2013 17:10:19 +0000 (18:10 +0100)
commit4161824f18ff4f56f46595a4016c7315dd0d24f1
tree0543311b70f8855f967fb41c3d7c3bf61c0c8a09
parent84d7ed799fd6c1366547d88ddb8188c65de3b94f
uprobes/tracing: Fully initialize uprobe_trace_consumer before uprobe_register()

probe_event_enable() does uprobe_register() and only after that sets
utc->tu and tu->consumer/flags. This can race with uprobe_dispatcher()
which can miss these assignments or see them out of order. Nothing
really bad can happen, but this doesn't look clean/safe.

And this does not allow to use uprobe_consumer->filter() we are going
to add, it is called by uprobe_register() and it needs utc->tu.

Change this code to initialize everything before uprobe_register(), and
reset tu->consumer/flags if it fails. We can't race with event_disable(),
the caller holds event_mutex, and if we could the code would be wrong
anyway.

In fact I think uprobe_trace_consumer should die, it buys nothing but
complicates the code. We can simply add uprobe_consumer into trace_uprobe.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
kernel/trace/trace_uprobe.c