RDMA/hns: Fix memory leak on 'context' on error return path
authorColin Ian King <colin.king@canonical.com>
Thu, 24 Oct 2019 13:10:34 +0000 (14:10 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Dec 2019 15:44:27 +0000 (16:44 +0100)
commit415f3ae6912d0d25ee6257e8ffc5a61293b61e9c
treec93b8f763d2226036d0441700782a7e0d2d70a79
parent24b758dcd569b00c2c9adfcb0da19a9af124342e
RDMA/hns: Fix memory leak on 'context' on error return path

[ Upstream commit 994195e1537074f56df216a9309f6e366cb35b67 ]

Currently, the error return path when the call to function
dev->dfx->query_cqc_info fails will leak object 'context'. Fix this by
making the error return path via 'err' return return codes rather than
-EMSGSIZE, set ret appropriately for all error return paths and for the
memory leak now return via 'err' rather than just returning without
freeing context.

Link: https://lore.kernel.org/r/20191024131034.19989-1-colin.king@canonical.com
Addresses-Coverity: ("Resource leak")
Fixes: e1c9a0dc2939 ("RDMA/hns: Dump detailed driver-specific CQ")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/hw/hns/hns_roce_restrack.c