[NewPM] teach -passes= to emit meaningful error messages
authorFedor Sergeev <fedor.sergeev@azul.com>
Mon, 15 Oct 2018 15:00:18 +0000 (15:00 +0000)
committerFedor Sergeev <fedor.sergeev@azul.com>
Mon, 15 Oct 2018 15:00:18 +0000 (15:00 +0000)
commit4155a77e98e151d3f5680475b564f7cfe07cb975
treeba22911ff008989fad1831f8c6f42355db9fea6b
parent6df0759aad02822aa89143b94c3fc39b0f816025
[NewPM] teach -passes= to emit meaningful error messages

Summary:
All the PassBuilder::parse interfaces now return descriptive StringError
instead of a plain bool. It allows to make -passes/aa-pipeline parsing
errors context-specific and thus less confusing.

TODO: ideally we should also make suggestions for misspelled pass names,
but that requires some extensions to PassBuilder.

Reviewed By: philip.pfaffe, chandlerc
Differential Revision: https://reviews.llvm.org/D53246

llvm-svn: 344519
12 files changed:
llvm/include/llvm/Passes/PassBuilder.h
llvm/lib/LTO/LTOBackend.cpp
llvm/lib/Passes/PassBuilder.cpp
llvm/test/Other/pass-pipeline-parsing.ll
llvm/test/tools/llvm-lto2/X86/pipeline.ll
llvm/test/tools/llvm-opt-fuzzer/command-line.ll
llvm/tools/llvm-opt-fuzzer/llvm-opt-fuzzer.cpp
llvm/tools/opt/NewPMDriver.cpp
llvm/unittests/IR/CMakeLists.txt
llvm/unittests/IR/PassBuilderCallbacksTest.cpp
llvm/unittests/Passes/CMakeLists.txt
llvm/unittests/Passes/PluginsTest.cpp