staging: unisys: visornic: prevent double-unlock of priv_lock
authorTim Sell <Timothy.Sell@unisys.com>
Fri, 8 Apr 2016 13:21:10 +0000 (09:21 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Apr 2016 04:15:51 +0000 (21:15 -0700)
commit4145ba76b1f7f3296cc673c299084145e1267029
treea6f868ef06915442258bab975425fd4f9379649c
parent6fac083b8df8450af4550238faa104396ccecf13
staging: unisys: visornic: prevent double-unlock of priv_lock

Previously, devdata->priv_lock was being unlocked in visornic_serverdown()
both before calling visornic_serverdown_complete(), then again at the end
of the function.  This bug was corrected.

The structure of visornic_serverdown() was also improved to make it easier
to follow and to decrease the chance that such bugs will be introduced
again.  The main-path logic now falls thru down the left-side of the page,
with a common error-exit point to handle error conditions.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visornic/visornic_main.c