bnx2x: Prevent load reordering in tx completion processing
authorBrian King <brking@linux.vnet.ibm.com>
Mon, 15 Jul 2019 21:41:50 +0000 (16:41 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 4 Aug 2019 07:33:32 +0000 (09:33 +0200)
commit408f14de0ab6b9242f6b2809b12c772e19336350
tree439950fcc64c69e480acf89cdce11ca785f0a633
parent3f0307b0d2d8b333a6964fc4c820dc86896fd1cf
bnx2x: Prevent load reordering in tx completion processing

[ Upstream commit ea811b795df24644a8eb760b493c43fba4450677 ]

This patch fixes an issue seen on Power systems with bnx2x which results
in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb
pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons
load in bnx2x_tx_int. Adding a read memory barrier resolves the issue.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c