Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions
authorCarlos Galvez <carlosgalvezp@gmail.com>
Tue, 12 Oct 2021 14:05:43 +0000 (10:05 -0400)
committerAaron Ballman <aaron@aaronballman.com>
Tue, 12 Oct 2021 14:08:08 +0000 (10:08 -0400)
commit40546cb38189e438a81faa6400c103d159600f9e
treeade05e1be50af58374e02512ab48011f5ffee4e0
parent564e082d0954e0beebfff994ac03471d926cd1d1
Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

This requirement was introduced in the C++ Core guidelines in 2016:

https://github.com/isocpp/CppCoreGuidelines/commit/1894380d0abf4d7d49a983005647e0d41ecbf214

Then clang-tidy got updated to comply with the rule.

However in 2019 this decision was reverted:

https://github.com/isocpp/CppCoreGuidelines/commit/5fdfb20b760c5307bf86873798a146fcd7e912e6

Therefore we need to apply the correct configuration to
clang-tidy again.

This also makes this cppcoreguidelines check consistent
with the other 2 alias checks: hicpp-use-override and
modernize-use-override.

Additionally, add another RUN line to the unit test,
to make sure cppcoreguidelines-explicit-virtual-functions
is tested.
clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tools-extra/docs/ReleaseNotes.rst
clang-tools-extra/test/clang-tidy/checkers/modernize-use-override.cpp