drm/i915/gt: remove some limited use register access wrappers
authorJani Nikula <jani.nikula@intel.com>
Wed, 23 Nov 2022 16:49:16 +0000 (18:49 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 7 Dec 2022 11:24:15 +0000 (13:24 +0200)
commit4050e6f211ea521eb703c921cdb15b905be882b2
tree98749f77ba647d596f6ac8dc066041365a2257f6
parent3d0f98fa66bc459d0ba516d1d46a0b22e3005244
drm/i915/gt: remove some limited use register access wrappers

Remove rmw_set(), rmw_clear(), clear_register(), rmw_set_fw(), and
rmw_clear_fw(). They're just one too many levels of abstraction for
register access, for very specific purposes.

clear_register() seems like a micro-optimization bypassing the write
when the register is already clear, but that trick has ceased to work
since commit 06b975d58fd6 ("drm/i915: make intel_uncore_rmw() write
unconditionally"). Just clear the register in the most obvious way.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221123164916.4128733-1-jani.nikula@intel.com
drivers/gpu/drm/i915/gt/intel_gt.c
drivers/gpu/drm/i915/gt/intel_reset.c