Revert "pstore: migrate to crypto acomp interface"
authorGuilherme G. Piccoli <gpiccoli@igalia.com>
Thu, 29 Sep 2022 21:55:15 +0000 (18:55 -0300)
committerKees Cook <keescook@chromium.org>
Fri, 30 Sep 2022 15:16:06 +0000 (08:16 -0700)
commit40158dbf7eb2b13d8851fe0b875b4c3170ea15db
treed9b0e163ac2fa7179650c5538ec7c1962040518e
parent568035b01cfb107af8d2e4bd2fb9aea22cf5b868
Revert "pstore: migrate to crypto acomp interface"

This reverts commit e4f0a7ec586b7644107839f5394fb685cf1aadcc.

When using this new interface, both efi_pstore and ramoops
backends are unable to properly decompress dmesg if using
zstd, lz4 and lzo algorithms (and maybe more). It does succeed
with deflate though.

The message observed in the kernel log is:

[2.328828] pstore: crypto_acomp_decompress failed, ret = -22!

The pstore infrastructure is able to collect the dmesg with
both backends tested, but since decompression fails it's
unreadable. With this revert everything is back to normal.

Fixes: e4f0a7ec586b ("pstore: migrate to crypto acomp interface")
Cc: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220929215515.276486-1-gpiccoli@igalia.com
fs/pstore/platform.c