drm/stm: fix warning about multiplication in condition
authorArnd Bergmann <arnd@arndb.de>
Wed, 6 Sep 2017 13:13:07 +0000 (15:13 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 8 Sep 2017 08:29:11 +0000 (10:29 +0200)
commit3ff558e78bc517f10a1b087989f3fda87038b48c
treef6c73d3442f2ec5aa09199684edea61d83b538a3
parent34cc0aa2545603560c79aaea3340d8ff3a71bd10
drm/stm: fix warning about multiplication in condition

gcc-7 complains about multiplying within a condition being
suspicious:

drivers/gpu/drm/stm/dw_mipi_dsi-stm.c: In function 'dsi_pll_get_clkout_khz':
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c:117:10: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context]

The code here is correct, but can be easily rephrased to make
that more obvious. I also swap out the error handling and the normal
code path for clarity.

Fixes: b0f09a3c69d9 ("drm/stm: Add STM32 DSI controller driver")
Acked-by: Philippe Cornu <philippe.cornu@st.com>
Tested-by: Philippe Cornu <philippe.cornu@st.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20170906131331.2691300-1-arnd@arndb.de
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c