iommu/rockchip: Handle errors returned from PM framework
authorMarc Zyngier <marc.zyngier@arm.com>
Fri, 24 Aug 2018 15:06:36 +0000 (16:06 +0100)
committerOlof Johansson <olof@lixom.net>
Fri, 24 Aug 2018 15:50:29 +0000 (08:50 -0700)
commit3fc7c5c0cff3150e471f5fd12f59971c6d2c6513
tree34f6108a8a74f52907f0a5c74b9f6d879643ffca
parent7db7a8f5638a2ffe0c0c0d55b5186b6191fd6af7
iommu/rockchip: Handle errors returned from PM framework

pm_runtime_get_if_in_use can fail: either PM has been disabled
altogether (-EINVAL), or the device hasn't been enabled yet (0).
Sadly, the Rockchip IOMMU driver tends to conflate the two things
by considering a non-zero return value as successful.

This has the consequence of hiding other bugs, so let's handle this
case throughout the driver, with a WARN_ON_ONCE so that we can try
and work out what happened.

Fixes: 0f181d3cf7d98 ("iommu/rockchip: Add runtime PM support")
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
drivers/iommu/rockchip-iommu.c