soundwire: fix double free of dangling pointer
authorTom Rix <trix@redhat.com>
Wed, 2 Sep 2020 20:26:50 +0000 (13:26 -0700)
committerVinod Koul <vkoul@kernel.org>
Thu, 3 Sep 2020 08:40:19 +0000 (14:10 +0530)
commit3fbbf2148a406b3e350fe91e6fdd78eb42ecad24
tree79cb08c99781796ffd76a1b38c86da4f57d5d258
parentf8d0168e035f6359275efcfd1ad014c80e5adaa9
soundwire: fix double free of dangling pointer

clang static analysis flags this problem

stream.c:844:9: warning: Use of memory after
  it is freed
        kfree(bus->defer_msg.msg->buf);
              ^~~~~~~~~~~~~~~~~~~~~~~

This happens in an error handler cleaning up memory
allocated for elements in a list.

list_for_each_entry(m_rt, &stream->master_list, stream_node) {
bus = m_rt->bus;

kfree(bus->defer_msg.msg->buf);
kfree(bus->defer_msg.msg);
}

And is triggered when the call to sdw_bank_switch() fails.
There are a two problems.

First, when sdw_bank_switch() fails, though it frees memory it
does not clear bus's reference 'defer_msg.msg' to that memory.

The second problem is the freeing msg->buf. In some cases
msg will be NULL so this will dereference a null pointer.
Need to check before freeing.

Fixes: 99b8a5d608a6 ("soundwire: Add bank switch routine")
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200902202650.14189-1-trix@redhat.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/stream.c