projects / platform / upstream / llvm.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: fd61354) | patch
Fix dangling reference in DwarfLinker.cpp. The original code
authorYaron Keren <yaron.keren@gmail.com>
Sat, 8 Aug 2015 21:03:19 +0000 (21:03 +0000)
committerYaron Keren <yaron.keren@gmail.com>
Sat, 8 Aug 2015 21:03:19 +0000 (21:03 +0000)
commit3f85a22cf93bd86017b273fbddb982ed6584d84f
tree4390a0eee43b05e99a421a42dd07fc97e3569766tree | snapshot
parentfd613545cb235993108f07c8d79bd9f37ee1e80ecommit | diff
Fix dangling reference in DwarfLinker.cpp. The original code

  Seq.emplace_back(Seq.back());

does not work as planned, since Seq.back() may become a dangling reference
when emplace_back is called and possibly reallocates vector. To avoid this,
the vector allocation should be reserved first and only then used.

This broke test/tools/dsymutil/X86/custom-line-table.test with Visual C++ 2013.

llvm-svn: 244405
llvm/tools/dsymutil/DwarfLinker.cpp diff | blob | history
Domain: System / Toolchain;