fs/ext4: use try_cmpxchg in ext4_update_bh_state
authorUros Bizjak <ubizjak@gmail.com>
Wed, 2 Nov 2022 07:11:47 +0000 (08:11 +0100)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 3 Feb 2023 06:50:07 +0000 (22:50 -0800)
commit3ee2a3e7c1ca3b263c41cff81619ab1d200fadfb
tree313524c855b5461998f72558e738053259a2c28a
parent74b7046d329770ea9dd105ca321ad6abb91bdbbb
fs/ext4: use try_cmpxchg in ext4_update_bh_state

Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
ext4_update_bh_state.  x86 CMPXCHG instruction returns success in ZF flag,
so this change saves a compare after cmpxchg (and related move instruction
in front of cmpxchg).

Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg
fails.  There is no need to re-read the value in the loop.

No functional change intended.

Link: https://lkml.kernel.org/r/20221102071147.6642-1-ubizjak@gmail.com
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/ext4/inode.c