Fix Clang -Wunreachable-code-aggressive warnings
authorJames Zern <jzern@google.com>
Sat, 3 Jun 2023 01:49:00 +0000 (18:49 -0700)
committerJames Zern <jzern@google.com>
Wed, 28 Jun 2023 18:06:50 +0000 (11:06 -0700)
commit3ecba398023dea731520cc1489159bfd0ad0a200
treee271dd94dce3cf92ad0186c709d36ae7b6084dbe
parent44d6cacec62bf81937b577c6d1cb19d18d31dd63
Fix Clang -Wunreachable-code-aggressive warnings

Based on the change in libaom:
fe36011455 Fix Clang -Wunreachable-code-aggressive warnings

Clang's -Wunreachable-code-aggressive flag enables several warning flags
such as -Wunreachable-code-break and -Wunreachable-code-return. Chrome's
build system enables -Wunreachable-code-aggressive (in
build/config/compiler/BUILD.gn), so it would be good if libvpx could be
compiled without -Wunreachable-code-aggressive warnings.

This requires the VPX_NO_RETURN macro be defined correctly for all the
compilers we support, otherwise some compilers may warn about missing
return statements after a die() or fatal() call (which does not return).

Change-Id: I0c069133af45a7a61759538b6d74c681ea087dcd
13 files changed:
args.c
configure
examples/vp9_spatial_svc_encoder.c
test/partial_idct_test.cc
test/vp9_ratectrl_rtc_test.cc
tools_common.c
vp8/decoder/decodeframe.c
vp8/encoder/firstpass.c
vp9/encoder/vp9_ext_ratectrl.c
vp9/encoder/vp9_firstpass.c
vp9/encoder/vp9_mbgraph.c
vp9/simple_encode.cc
vpxdec.c