PCI/AER: Move pci_uevent_ers() out of pci.h
authorMichael Ellerman <mpe@ellerman.id.au>
Thu, 8 Feb 2018 12:20:35 +0000 (23:20 +1100)
committerBjorn Helgaas <helgaas@kernel.org>
Thu, 22 Feb 2018 23:04:59 +0000 (17:04 -0600)
commit3ecac020d6dd09259414f423b577347ebee9f533
treea8df44b4b1d68716fcb3ca4030b10a18d930edfc
parent7928b2cbe55b2a410a0f5c1f154610059c57b1b2
PCI/AER: Move pci_uevent_ers() out of pci.h

There's no reason pci_uevent_ers() needs to be inline in pci.h, so move it
out to a C file.

Given it's used by AER the obvious location would be somewhere in
drivers/pci/pcie/aer, but because it's also used by powerpc EEH code
unfortunately that doesn't work in the case where EEH is enabled but
PCIEPORTBUS is not.

So for now put it in pci-driver.c, next to pci_uevent(), with an
appropriate #ifdef so it's not built if AER and EEH are both disabled.

While we're moving it also fix up the kernel doc comment for @pdev to be
accurate.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Bjorn Helgaas <helgaas@kernel.org>
Reviewed-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
drivers/pci/pci-driver.c
include/linux/pci.h