media: usb: msi2500: Fix a possible null-pointer dereference in msi2500_stop_streaming()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 29 Jul 2019 10:14:44 +0000 (12:14 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 27 Nov 2020 07:02:13 +0000 (08:02 +0100)
commit3ec7fdc58363bb204c75d6158e3560fd7cabbf5c
treeeab3f800b888abb9ac39938b67927530ff9d68eb
parentbf9d46f751e75bf3d9a48bd69675f95d86ff7eb9
media: usb: msi2500: Fix a possible null-pointer dereference in msi2500_stop_streaming()

In msi2500_stop_streaming(), there is an if statement on line 870 to
check whether dev->udev is NULL:
    if (dev->udev)

When dev->udev is NULL, it is used on line 877:
    msi2500_ctrl_msg(dev, CMD_STOP_STREAMING, 0)
        usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0), ...)

Thus, a possible null-pointer dereference may occur.

To fix this bug, dev->udev is checked before calling msi2500_ctrl_msg().

This bug is found by a static analysis tool STCheck written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/usb/msi2500/msi2500.c