projects / platform / kernel / linux-rpi.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 4262ee8) | patch
mtd: spi-nor: Fix an error code in spi_nor_read_raw()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 15 Aug 2019 08:32:52 +0000 (11:32 +0300)
committerTudor Ambarus <tudor.ambarus@microchip.com>
Wed, 21 Aug 2019 08:01:55 +0000 (11:01 +0300)
commit3e9e38d918bd01068b5ccba17d69a8ae9bf56142
treefd498692b4d0ddfba3ec06d821a79820f9c28c76tree | snapshot
parent4262ee88f07f6771eafcc5efa1050a7df1b88cb7commit | diff
mtd: spi-nor: Fix an error code in spi_nor_read_raw()

The problem is that if "ret" is negative then when we check if
"ret > len", that condition is going to be true because of type
promotion.  So this patch re-orders the code to check for negatives
first and preserve those error codes.

Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial Flash Discoverable Parameters (SFDP) tables")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
drivers/mtd/spi-nor/spi-nor.c diff | blob | history
Domain: System / Kernel;