cgroup-v1: add disabled controller check in cgroup1_parse_param()
authorChen Zhou <chenzhou10@huawei.com>
Fri, 15 Jan 2021 09:37:17 +0000 (17:37 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Feb 2021 10:02:25 +0000 (11:02 +0100)
commit3e53d64e9a4d88226fb1ab55900fe4e89e81df1e
tree6751f4ea1dfe91131c3f8808d2baa410e0273ddf
parent2aba53830f5d02dcd0bb74a00c8b8023df9d1398
cgroup-v1: add disabled controller check in cgroup1_parse_param()

[ Upstream commit 61e960b07b637f0295308ad91268501d744c21b5 ]

When mounting a cgroup hierarchy with disabled controller in cgroup v1,
all available controllers will be attached.
For example, boot with cgroup_no_v1=cpu or cgroup_disable=cpu, and then
mount with "mount -t cgroup -ocpu cpu /sys/fs/cgroup/cpu", then all
enabled controllers will be attached except cpu.

Fix this by adding disabled controller check in cgroup1_parse_param().
If the specified controller is disabled, just return error with information
"Disabled controller xx" rather than attaching all the other enabled
controllers.

Fixes: f5dfb5315d34 ("cgroup: take options parsing into ->parse_monolithic()")
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Reviewed-by: Zefan Li <lizefan.x@bytedance.com>
Reviewed-by: Michal Koutný <mkoutny@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/cgroup/cgroup-v1.c