mtd: phram: Prevent divide by zero bug in phram_setup()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 21 Jan 2022 11:55:05 +0000 (14:55 +0300)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 25 Jan 2022 09:32:07 +0000 (10:32 +0100)
commit3e3765875b1b8864898603768fd5c93eeb552211
treecc469397df15bc29a8360eb14a716788f3935090
parent4cd335dae3cf25412427938d8abbaf04d46e63b5
mtd: phram: Prevent divide by zero bug in phram_setup()

The problem is that "erasesize" is a uint64_t type so it might be
non-zero but the lower 32 bits are zero so when it's truncated,
"(uint32_t)erasesize", then that value is zero. This leads to a
divide by zero bug.

Avoid the bug by delaying the divide until after we have validated
that "erasesize" is non-zero and within the uint32_t range.

Fixes: dc2b3e5cbc80 ("mtd: phram: use div_u64_rem to stop overwrite len in phram_setup")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220121115505.GI1978@kadam
drivers/mtd/devices/phram.c