Change llvm-ar to use lib/Object.
authorRafael Espindola <rafael.espindola@gmail.com>
Fri, 12 Jul 2013 20:21:39 +0000 (20:21 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Fri, 12 Jul 2013 20:21:39 +0000 (20:21 +0000)
commit3e2b21cd4d49d3b641cecef413a706595dba9ce5
tree71e93b142b2ff0c0e5e77c1c69cf0d64361e3188
parentc22c790f894813ffe7310eaf0443c2b72a58e10d
Change llvm-ar to use lib/Object.

This fixes two bugs is lib/Object that the use in llvm-ar found:
* In OS X created archives, the name can be padded with nulls. Strip them.
* In the constructor, remember the first non special member and use that in
  begin_children. This makes sure we skip all special members, not just the
  first one.

The change to llvm-ar itself consist of
* Using lib/Object for reading archives instead of ArchiveReader.cpp.
* Writing the modified archive directly, instead of creating an in memory
  representation.

The old Archive library was way more general than what is needed, as can
be seen by the diffstat of this patch.

Having llvm-ar using lib/Object now opens the way for creating regular symbol
tables for both native objects and bitcode files so that we can use those
archives for LTO.

llvm-svn: 186197
llvm/include/llvm/Object/Archive.h
llvm/lib/Object/Archive.cpp
llvm/test/Object/archive-toc.test
llvm/test/Object/directory.ll
llvm/tools/llvm-ar/Archive.cpp [deleted file]
llvm/tools/llvm-ar/ArchiveInternals.h [deleted file]
llvm/tools/llvm-ar/ArchiveReader.cpp [deleted file]
llvm/tools/llvm-ar/ArchiveWriter.cpp [deleted file]
llvm/tools/llvm-ar/CMakeLists.txt
llvm/tools/llvm-ar/llvm-ar.cpp