projects / platform / upstream / gstreamer.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f8196e0) | patch
Use gst_element_class_set_metadata when passing dynamic strings
authorJordan Petridis <jpetridis@gnome.org>
Thu, 11 Jun 2020 17:39:33 +0000 (20:39 +0300)
committerJordan Petridis <jpetridis@gnome.org>
Thu, 11 Jun 2020 17:39:33 +0000 (20:39 +0300)
commit3e2420361a3d04dfb44acf53d91cc5849ec9ad01
tree30f7930137dcd98c94c374b592b74e8937145232tree | snapshot
parentf8196e06d53b7831c333f9da296a3a7d7ad75f38commit | diff
Use gst_element_class_set_metadata when passing dynamic strings

gst_element_class_set_metadata is meant to only be used with
static or inlined strings, which isn't the case for the 2 elements
here resulting in use-after-free later on.

https://gstreamer.freedesktop.org/documentation/gstreamer/gstelement.html?gi-language=c#gst_element_class_set_static_metadata

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/622>
gst/isomp4/gstqtmux.c diff | blob | history
sys/v4l2/gstv4l2videodec.c diff | blob | history
Domain: Multimedia / Media Common;