crypto: blake2s - remove shash module
authorJason A. Donenfeld <Jason@zx2c4.com>
Sat, 28 May 2022 19:44:07 +0000 (21:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:24:19 +0000 (14:24 +0200)
commit3dd33a09f5dc12ccb0902923c4c784eb0f8c7554
tree9b09447dd229a77f43221e94840d623aaf246d85
parentf96a9815b46633b4e5c34d174135bafac9f550a8
crypto: blake2s - remove shash module

[ Upstream commit 2d16803c562ecc644803d42ba98a8e0aef9c014e ]

BLAKE2s has no currently known use as an shash. Just remove all of this
unnecessary plumbing. Removing this shash was something we talked about
back when we were making BLAKE2s a built-in, but I simply never got
around to doing it. So this completes that project.

Importantly, this fixs a bug in which the lib code depends on
crypto_simd_disabled_for_test, causing linker errors.

Also add more alignment tests to the selftests and compare SIMD and
non-SIMD compression functions, to make up for what we lose from
testmgr.c.

Reported-by: gaochao <gaochao49@huawei.com>
Cc: Eric Biggers <ebiggers@kernel.org>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: stable@vger.kernel.org
Fixes: 6048fdcc5f26 ("lib/crypto: blake2s: include as built-in")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
15 files changed:
arch/arm/crypto/Kconfig
arch/arm/crypto/Makefile
arch/arm/crypto/blake2s-shash.c [deleted file]
arch/x86/crypto/Makefile
arch/x86/crypto/blake2s-glue.c
arch/x86/crypto/blake2s-shash.c [deleted file]
crypto/Kconfig
crypto/Makefile
crypto/blake2s_generic.c [deleted file]
crypto/tcrypt.c
crypto/testmgr.c
crypto/testmgr.h
include/crypto/internal/blake2s.h
lib/crypto/blake2s-selftest.c
lib/crypto/blake2s.c