ceph: add auth buf in prepare_write_connect()
authorAlex Elder <elder@inktank.com>
Wed, 16 May 2012 20:16:39 +0000 (15:16 -0500)
committerSage Weil <sage@inktank.com>
Sat, 19 May 2012 00:35:59 +0000 (17:35 -0700)
commit3da54776e2c0385c32d143fd497a7f40a88e29dd
tree4dac17103404f8f5a967c6855bcb9891080a600b
parentdac1e716c60161867a47745bca592987ca3a9cb2
ceph: add auth buf in prepare_write_connect()

Move the addition of the authorizer buffer to a connection's
out_kvec out of get_connect_authorizer() and into its caller.  This
way, the caller--prepare_write_connect()--can avoid adding the
connect header to out_kvec before it has been fully initialized.

Prior to this patch, it was possible for a connect header to be
sent over the wire before the authorizer protocol or buffer length
fields were initialized.  An authorizer buffer associated with that
header could also be queued to send only after the connection header
that describes it was on the wire.

Fixes http://tracker.newdream.net/issues/2424

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
net/ceph/messenger.c