[llvm-readobj] - Remove Error.cpp,.h and drop dependencies in the code.
authorGeorgii Rymar <grimar@accesssoftek.com>
Fri, 28 Aug 2020 09:18:19 +0000 (12:18 +0300)
committerGeorgii Rymar <grimar@accesssoftek.com>
Tue, 1 Sep 2020 13:46:17 +0000 (16:46 +0300)
commit3d90a61cf2edc22f1f006de351a1812592a7648b
tree1f0ff72dc6b8200f943e9b74f3fabd746f7a5b40
parentd48699e3e89f342ecb9dfc288f6840cd41ecb5e5
[llvm-readobj] - Remove Error.cpp,.h and drop dependencies in the code.

We have Error.cpp/.h which contains some code for working with error codes.
In fact we use Error/Expected<> almost everywhere already and we can get rid
of these files.

Note: a few places in the code used readobj specific error codes,
e.g. `return readobj_error::unknown_symbol`. But these codes are never really used,
i.e. the code checks the fact of a success/error call only.
So I've changes them to `return inconvertibleErrorCode()` for now.
It seems that these places probably should be converted to use `Error`/`Expected<>`.

Differential revision: https://reviews.llvm.org/D86772
16 files changed:
llvm/test/tools/llvm-readobj/archive.test
llvm/tools/llvm-readobj/ARMEHABIPrinter.h
llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp
llvm/tools/llvm-readobj/CMakeLists.txt
llvm/tools/llvm-readobj/COFFDumper.cpp
llvm/tools/llvm-readobj/DwarfCFIEHPrinter.h
llvm/tools/llvm-readobj/ELFDumper.cpp
llvm/tools/llvm-readobj/Error.cpp [deleted file]
llvm/tools/llvm-readobj/Error.h [deleted file]
llvm/tools/llvm-readobj/MachODumper.cpp
llvm/tools/llvm-readobj/ObjDumper.cpp
llvm/tools/llvm-readobj/WasmDumper.cpp
llvm/tools/llvm-readobj/Win64EHDumper.cpp
llvm/tools/llvm-readobj/WindowsResourceDumper.cpp
llvm/tools/llvm-readobj/XCOFFDumper.cpp
llvm/tools/llvm-readobj/llvm-readobj.cpp