x86-64: Add R_X86_64_CODE_4_GOTPCRELX
authorH.J. Lu <hjl.tools@gmail.com>
Thu, 8 Jun 2023 17:01:03 +0000 (10:01 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Thu, 28 Dec 2023 16:47:17 +0000 (08:47 -0800)
commit3d5a60de52556f6a53d71d7e607c6696450ae3e4
treecf1a1b08ee6c9814716b5f6e5953cf9d6686f47b
parent5e2f0c9a5f3d467a341a0c3d579d9c6ee6daa4d1
x86-64: Add R_X86_64_CODE_4_GOTPCRELX

For

mov        name@GOTPCREL(%rip), %reg
test       %reg, name@GOTPCREL(%rip)
binop      name@GOTPCREL(%rip), %reg

where binop is one of adc, add, add, cmp, or, sbb, sub, xor instructions,
add

 # define R_X86_64_CODE_4_GOTPCRELX  43

if the instruction starts at 4 bytes before the relocation offset.  It
similar to R_X86_64_GOTPCRELX.  Linker can treat R_X86_64_CODE_4_GOTPCRELX
as R_X86_64_GOTPCREL or convert the above instructions to

lea name(%rip), %reg
mov $name, %reg
test $name, %reg
binop $name, %reg

if the instruction is encoded with the REX2 prefix when possible.

bfd/

* elf64-x86-64.c (x86_64_elf_howto_table): Add
R_X86_64_CODE_4_GOTPCRELX.
(R_X86_64_standard): Updated.
(x86_64_reloc_map): Add BFD_RELOC_X86_64_CODE_4_GOTPCRELX.
(elf_x86_64_convert_load_reloc): Handle R_X86_64_CODE_4_GOTPCRELX.
(elf_x86_64_scan_relocs): Likewise.
(elf_x86_64_relocate_section): Likewise.
* reloc.c (bfd_reloc_code_real): Add
BFD_RELOC_X86_64_CODE_4_GOTPCRELX.
* bfd-in2.h: Regenerated.
* libbfd.h: Likewise.

gas/

* write.h (fix): Add fx_tcbit3.  Change fx_unused to 1 bit.
* config/tc-i386.c (tc_i386_fix_adjustable): Handle
BFD_RELOC_X86_64_CODE_4_GOTPCRELX.
(tc_gen_reloc): Likewise.
(output_disp): Set fixP->fx_tcbit3 for REX2 prefix.
(i386_validate_fix): Generate BFD_RELOC_X86_64_CODE_4_GOTPCRELX
if fixp->fx_tcbit3 is set.
* config/tc-i386.h (TC_FORCE_RELOCATION_LOCAL): Add
BFD_RELOC_X86_64_CODE_4_GOTPCRELX.
(TC_FORCE_RELOCATION_ABS): Likewise.
* testsuite/gas/i386/x86-64-gotpcrel.s: Add tests for
R_X86_64_CODE_4_GOTPCRELX.
* testsuite/gas/i386/x86-64-localpic.s: Likewise.
* testsuite/gas/i386/x86-64-gotpcrel.d: Updated.
* testsuite/gas/i386/x86-64-localpic.d: Likewise.
* testsuite/gas/i386/ilp32/x86-64-localpic.d: Likewise.

include/

* elf/x86-64.h (elf_x86_64_reloc_type): Add
R_X86_64_CODE_4_GOTPCRELX.

ld/

* testsuite/ld-x86-64/apx-load1.s: New file.
* testsuite/ld-x86-64/apx-load1a.d: Likewise.
* testsuite/ld-x86-64/apx-load1b.d: Likewise.
* testsuite/ld-x86-64/apx-load1c.d: Likewise.
* testsuite/ld-x86-64/apx-load1d.d: Likewise.
* testsuite/ld-x86-64/x86-64.exp: Run apx-load1a, apx-load1b,
apx-load1c and apx-load1d.
19 files changed:
bfd/bfd-in2.h
bfd/elf64-x86-64.c
bfd/libbfd.h
bfd/reloc.c
gas/config/tc-i386.c
gas/config/tc-i386.h
gas/testsuite/gas/i386/ilp32/x86-64-localpic.d
gas/testsuite/gas/i386/x86-64-gotpcrel.d
gas/testsuite/gas/i386/x86-64-gotpcrel.s
gas/testsuite/gas/i386/x86-64-localpic.d
gas/testsuite/gas/i386/x86-64-localpic.s
gas/write.h
include/elf/x86-64.h
ld/testsuite/ld-x86-64/apx-load1.s [new file with mode: 0644]
ld/testsuite/ld-x86-64/apx-load1a.d [new file with mode: 0644]
ld/testsuite/ld-x86-64/apx-load1b.d [new file with mode: 0644]
ld/testsuite/ld-x86-64/apx-load1c.d [new file with mode: 0644]
ld/testsuite/ld-x86-64/apx-load1d.d [new file with mode: 0644]
ld/testsuite/ld-x86-64/x86-64.exp