[libomptarget][nfc] Move omp locks under target_impl
authorJonChesterfield <jonathanchesterfield@gmail.com>
Tue, 17 Dec 2019 12:18:55 +0000 (12:18 +0000)
committerJon Chesterfield <jonathanchesterfield@gmail.com>
Tue, 17 Dec 2019 12:18:57 +0000 (12:18 +0000)
commit3d3e4076cd65007007ca639d4f99c0fa671c9f8e
tree2a34982ad8342ae0e464fa476c5b83608544651f
parent5666b70fd0748765ecaa69950a4868cf23a16cc9
[libomptarget][nfc] Move omp locks under target_impl

Summary:
[libomptarget][nfc] Move omp locks under target_impl

These are likely to be target specific, even down to the lock_t which is
correspondingly moved out of interface.h. The alternative is to include
interface.h in target_impl which substantiatially increases the scope of
those symbols.

The current nvptx implementation deadlocks on amdgcn. The preferred
implementation for that arch is still under discussion - this change
leaves declarations in target_impl.

The functions could be inline for nvptx. I'd prefer to keep the internals
hidden in the target_impl translation unit, but will add the (possibly renamed)
macros to target_impl.h if preferred.

Reviewers: ABataev, jdoerfert, grokos

Reviewed By: jdoerfert

Subscribers: jvesely, mgorny, jfb, openmp-commits

Tags: #openmp

Differential Revision: https://reviews.llvm.org/D71574
openmp/libomptarget/deviceRTLs/amdgcn/src/amdgcn_interface.h
openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
openmp/libomptarget/deviceRTLs/interface.h
openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt
openmp/libomptarget/deviceRTLs/nvptx/src/libcall.cu
openmp/libomptarget/deviceRTLs/nvptx/src/nvptx_interface.h
openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu [new file with mode: 0644]
openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h