kobject: fix dereference before null check on kobj
authorColin Ian King <colin.king@canonical.com>
Wed, 1 May 2019 12:43:17 +0000 (13:43 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 May 2019 13:08:38 +0000 (15:08 +0200)
commit3d378dc713f3ff4951d9a50c6a815f011e59da10
tree3331ef1d2ee94ef2b273ab1ec058e63641250483
parent391c0325cc5f9e2daf9117825714d777b3595a42
kobject: fix dereference before null check on kobj

The kobj pointer is being null-checked so potentially it could be null,
however, the ktype declaration before the null check is dereferencing kobj
hence we have a potential null pointer deference. Fix this by moving the
assignment of ktype after kobj has been null checked.

Addresses-Coverity: ("Dereference before null check")
Fixes: aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/kobject.c