hurd: keep only required PLTs in ld.so
authorSamuel Thibault <samuel.thibault@ens-lyon.org>
Tue, 10 Nov 2020 23:35:19 +0000 (23:35 +0000)
committerSamuel Thibault <samuel.thibault@ens-lyon.org>
Wed, 11 Nov 2020 01:36:22 +0000 (02:36 +0100)
commit3d3316b1dee885153d44210b2e95dba68d00613a
tree997c7734e51a76d2c11d0bfb5227f463c75df2e2
parenta40b18b2330026cedc07348481bf3219f668adca
hurd: keep only required PLTs in ld.so

We need NO_RTLD_HIDDEN because of the need for PLT calls in ld.so.
See Roland's comment in
https://sourceware.org/bugzilla/show_bug.cgi?id=15605
"in the Hurd it's crucial that calls like __mmap be the libc ones
instead of the rtld-local ones after the bootstrap phase, when the
dynamic linker is being used for dlopen and the like."

We used to just avoid all hidden use in the rtld ; this commit switches to
keeping only those that should use PLT calls, i.e. essentially those defined in
sysdeps/mach/hurd/dl-sysdep.c:

__assert_fail
__assert_perror_fail
__*stat64
_exit

This fixes a few startup issues, notably the call to __tunable_get_val that is
made before PLTs are set up.
17 files changed:
elf/dl-minimal.c
include/dirent.h
include/libc-internal.h
include/libc-symbols.h
include/setjmp.h
include/signal.h
include/stdlib.h
include/string.h
include/sys/utsname.h
include/unistd.h
sysdeps/generic/_itoa.h
sysdeps/i386/dl-tlsdesc.S
sysdeps/mach/hurd/_exit.c
sysdeps/mach/hurd/dl-sysdep.c
sysdeps/mach/hurd/i386/ld.abilist
sysdeps/mach/hurd/i386/localplt.data
sysdeps/x86_64/dl-tlsdesc.S