drm: mxsfb: Fix NULL pointer dereference crash on unload
authorMarek Vasut <marex@denx.de>
Sat, 16 Oct 2021 21:04:46 +0000 (23:04 +0200)
committerMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Thu, 21 Oct 2021 09:08:08 +0000 (11:08 +0200)
commit3cfc183052c3dbf8eae57b6c1685dab00ed3db4a
tree50d09174cdb7202bc6249c3fa695de7639d8b3df
parent519d81956ee277b4419c723adfb154603c2565ba
drm: mxsfb: Fix NULL pointer dereference crash on unload

The mxsfb->crtc.funcs may already be NULL when unloading the driver,
in which case calling mxsfb_irq_disable() via drm_irq_uninstall() from
mxsfb_unload() leads to NULL pointer dereference.

Since all we care about is masking the IRQ and mxsfb->base is still
valid, just use that to clear and mask the IRQ.

Fixes: ae1ed00932819 ("drm: mxsfb: Stop using DRM simple display pipeline helper")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Daniel Abrecht <public@danielabrecht.ch>
Cc: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Stefan Agner <stefan@agner.ch>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20211016210446.171616-1-marex@denx.de
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
drivers/gpu/drm/mxsfb/mxsfb_drv.c