radv: bind the non-dynamic graphics state from the pipeline unconditionally
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Mon, 30 Oct 2023 14:26:15 +0000 (15:26 +0100)
committerEric Engestrom <eric@engestrom.ch>
Wed, 1 Nov 2023 12:48:16 +0000 (12:48 +0000)
commit3cb8275141775d1eb3a2e7aee43a9755b9e86835
treeea4d82aadb086e5ce7b24191021a8e20e56c9e2d
parent14fac5200d4e5384c71d999318c9f891f6d3822c
radv: bind the non-dynamic graphics state from the pipeline unconditionally

The following sequence is valid (although weird) but many other drivers
(including RADV) were broken:
    - bind pipeline with some static state
    - set state command for that static state (to a bad value)
    - bind the same pipeline again
    - draw

Fixes new dEQP-VK.dynamic_state.*.double_static_bind.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25954>
(cherry picked from commit e4a1bc70dd739ca8addddc940af08312b038e288)
.pick_status.json
src/amd/vulkan/radv_cmd_buffer.c